“You aren’t writing enough lines of code!” - Management
I’m a bit disappointed there isn’t a call to GetBooleanValue in there
If this were a Node module, I wouldn’t even be surprised.
WTAF? Is this written by a hallucinating AI?
Straight from the famous book “Making LOCs for Dummies”
I misread it as CompareBolians. No more Star Trek memes for me today.
Many Bolians died bringing us this information.
Clearly it should be
return orig == val
Duh
To match the current behavior it should be orig != val
You’re hired. Can your start on Monday?
Don’t do OOP kids
That’s not OO code
Still good advice, though.
Not even once
Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.
Programmers:
I promote based on lines of code removed.
Which is all the easier to do when you start off with a higher number…
I quit based on idiotic metrics
Ah, the idiotic idiotic metric metric.
Are you 14?
I’m sure it was meant as a joke, not a serious criticism.
I think we can all agree that managers who have no idea what’s important absolutely suck
I love deleting code, including my own, more than writing code. That’s a killer metric imo.
Wait areBooleanEqual returns false when they are equal?
That’s not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.
The unnecessary and confusing functions are horrible, yes, but I’d still say that the fact that they’re wrong is the “worst” part.
That’s enough chit-chat, nerds. Back to work.
- Management
Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it’s both useless and terribly named.
yesn’t
This actually made me laugh, thank you.
Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.
Whoever wrote this is more than capable of using it incorrectly.
Don’t forget the invocation
if (CompareBooleans(a, b) == true)
if (CompareBooleans(CompareBooleans(a, b), true))
I don’t like this thread anymore :(
No, no, this is actually the only correct code in the thread.
that… actually works…
elseif(CompareBooleans(b,a) != false)
Is this part of Elons “How many lines of choice have you written?” interview?
This is code after working 16 hours
I’d give my right hand this is a code review problem. Someone extracted a method returning true false. Then an intern came along and was told to refactor. They saw a lot of comparisons and “extracted” them.
My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.
I’ve heard of shared libraries, but this is ridiculous
There’s no way, that’s so insane it has layers.
At first, I thought the shitty methods were the joke 😱😱😱