• becausechemistry@lemm.eeEnglish
    51·
    1 day ago

    Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.

    Programmers:

    • not_woody_shaw@lemmy.worldEnglish
      7·
      14 hours ago

      That’s not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.

      • BatmanAoD@lemmy.worldEnglish
        3·
        11 hours ago

        The unnecessary and confusing functions are horrible, yes, but I’d still say that the fact that they’re wrong is the “worst” part.

      • idunnololz@lemmy.worldEnglish
        5·
        13 hours ago

        Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it’s both useless and terribly named.

  • Grandwolf319@sh.itjust.worksEnglish
    28·
    1 day ago

    Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.

    Whoever wrote this is more than capable of using it incorrectly.

      • gwilikers@lemmy.mlEnglish
        1·
        1 hour ago

        I know. I didn’t say this was OOP, I said this was your brain when you OD on OOP. While we are not dealing with objects, I’d argue that the kind of approach that would lead one to needlessly overcompartmentalise code like this is the product of having a little too much OOP.

      • davidagain@lemmy.worldEnglish
        5·
        4 hours ago

        You’re right, this is just not oop AT ALL.

        For the correct OOP solution, you would need consider whether this can be thought of as a kind of stateless leaf method, and therefore implement it as an abstract (singleton) factory, but on the other hand, if you’re using a context object with the registry pattern, you should probably do this properly with IoC containers. Of course, if your object graph isn’t too complex or entangled, you could always just do constructor injection but you risk manging your unit tests, so I would go cautiously if I were looking in that direction.

        • collapse_already@lemmy.mlEnglish
          5·
          7 hours ago

          Shouldn’t there be a call to the boolean comparison microservices server in there somewhere? Also, we should consider the possibility that booleans and their operators could be overloaded to do something else entirely. We might need a server farm to handle all of the boolean comparison service requests.

          • davidagain@lemmy.worldEnglish
            2·
            4 hours ago

            SOLVED. On reflection, @collapse_already@lemmy.ml has come up with the perfect solution - let me explain,

            Parallelism

            YES. We should utilise a microservices architecture so that we can leverage a fundamental distributed interconnected parallelism to these boolean comparisons which is bound to beat naive single-thread, single-core calculation hands down. Already. But it gets better.

            Load balancing

            Of course a load balancing microservice would be useful because you don’t want one of the boolean comparison microservices accidentally taking too great a share of the computation, making the whole topology more brittle than it needs to be.

            Heuristics

            A boolean comparison request-comparing analytics microservice could evaluate different request distribution heuristics to the individual microservice nodes (for example targetting similar requests resolving to true/true or false/true etc versus fair-balancing-oriented server targetting versus pseudo-random distribution etc etc), and do so for randomly selected proportions of the uptime.

            Analysis

            The incoming boolean comparison requests would be tagged and logged for cross-reference and analysis, together with the computation times, the then-current request-distribution heuristic and the selected server, so that each heuristic can be analysed for effectiveness in different circumstances.

            Non-generative AI

            In fact, the simplest way of evaluating the different heuristic pragmas would be to input the aforementioned boolean comparison request logs, together with some general data on time of day/week/year and general performance metrics, into a neural network with a straightforward faster-is-better training programme, and pretty soon you’ll ORGANICALLY find the MOST EFFICIENT way of managing the boolean comparison requests.

            Executive summary:

            Organically evaluated stochastically-selected heuristics leverage AI for a monotonically-improving service metric, reducing costs and upscaling customer productivity on an ongoing basis without unnecessary unbillable human-led code improvement costs. Neural networks can be marketed under separate brands both as AI solutions and as LLM-free solutions, leveraging well-understood market segmentation techniques to drive revenues from disparate customer bases. Upgrade routes between the different marketing pathways can of course be monetised, but applying a 3%-above inflation mid-term customer inertia fee allows for prima-facia discounts when customers seek cost reduction-inspired pathway transfers, whilst ensuring underlying income increases that can be modelled as pervasive and overriding lower bounds for the two SAAS branches, independent of any customer churn, whilst well-placed marketing strategies can reasonably be expected to drive billable customer “upgrades” between pathways, mitigating any prima-facia discounts even before the underlying monotonicity price-structuring schemas.

          • davidagain@lemmy.worldEnglish
            3·
            4 hours ago

            What about a factory for the factories! There’s nothing more efficient than a tool making tool making tool.

  • Acters@lemmy.worldEnglish
    21·
    1 day ago

    Those are rookie lines of code numbers right there.
    I would have done it without the ==

    internal static bool AreBooleansEqual(bool orig, bool val)
{
    if(orig) 
    {
        if(val)
            return false
        return true
    }
    if(val)
        return true 
    return false
}

    Don’t know why their code returns false when they are equal but I’m not going to dig through old code to refactor to use true instead of false.

      • Acters@lemmy.worldEnglish
        2·
        19 hours ago

        I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too

    • InFerNo@lemmy.mlEnglish
      5·
      21 hours ago

      Put more curly brackets around your if (val) true statement for 4 more lines, put elses in there for more lines even.

      • Acters@lemmy.worldEnglish
        7·
        19 hours ago

        I should have created a local variable to store the result variable and return after the if statements. I just couldn’t help to make it look partially nice. My brain just doesn’t think at this high caliber of LOC optimizations.

        New optimized LOC version:

        internal static bool AreBooleansEqual(bool orig, bool val)
{
    bool result;
    if(orig) 
    {
        if(val)
        {
            result = false;
        }
        else
        {
            result = true;
        }
    }
    else
    {
        if(val)
        {
            result = true;
        }
        else
        {
            result = false;
        }
    }
    return result;
}

        My previous LOC: 12
        New LOC version: 27

        • servobobo@feddit.nlEnglish
          3·
          12 hours ago

          Surely we could optimize the return value with a switch statement and store the result as an integer to hide the compiler warning about our clearly correct code:

          internal static bool AreBooleansEqual(bool orig, bool val)
{
    int result;
    if(orig) 
    {
        if(val)
        {
            result = 0;
        }
        else
        {
            result = 1;
        }
    }
    else
    {
        if(val)
        {
            result = 1;
        }
        else
        {
            result = 0;
        }
    }
    switch (result)
    {
         case(1):
             return true;
         case(0):
             return false;
         default:
             return AreBooleansEqual(orig, val);
    }
}

          New LOC: 35

          • InFerNo@lemmy.mlEnglish
            2·
            10 hours ago

            Make the input variables nullable, then add checks if the values are null, then assign default values if they are, otherwise continue with the passed values.